Audio: Fix Xtensa HiFi5 build for audio processing components #9420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch avoids build error when testbench is built with a Xtensa HiFi5 tool chain. The changes select for HiFi5 the best option of available HiFi4 or HiFi3 code options. No HiFi5 specific optimizations are done. The updated components those got build issues are: DCblock, DRC, FIR, TDFB, and IIR. Signed-off-by: Seppo Ingalsuo <[email protected]>
lgirdwood
approved these changes
Sep 2, 2024
singalsu
requested review from
a team,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
kv2019i
reviewed
Sep 11, 2024
| @@ -18,7 +18,7 @@ | |||
| /* Unmark this define to use cordic arc sine implementation. */ | |||
| /* #define DRC_USE_CORDIC_ASIN */ | |||
|
|
|||
| #if SOF_USE_HIFI(4, DRC) || SOF_USE_HIFI(3, DRC) | |||
| #if SOF_USE_HIFI(5, DRC) || SOF_USE_HIFI(4, DRC) || SOF_USE_HIFI(3, DRC) | |||
There was a problem hiding this comment.
Yup, I agree with Curtis that this seems a bit silly and we'll have same problem with HIFI6/7. I think this macro continues to be valid for code that targets a specific hifi version, but given it seems we have code that should be compiled with whatever max hifi level, I think something like:
#define SOF_MIN_HIFI(level, component) (SOF_CONFIG_HIFI(level, component) || \
» (SOF_CONFIG_HIFI(MAX, component) && level <= SOF_MAX_XCHAL_HIFI))
and then use "SOF_MIN_HIFI(3, DRC)" in this code. Can you @singalsu test this out?
specifically uses
There was a problem hiding this comment.
Lets unblock for now, and align on a fix for v2.12. @singalsu pls self assign this feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch avoids build error when testbench is built with a Xtensa HiFi5 tool chain. The changes select for HiFi5 the best option of available HiFi4 or HiFi3 code options. No HiFi5 specific optimizations are done.
The updated components those got build issues are: DCblock, DRC, FIR, TDFB, and IIR.