Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipc4: helper: Remove hardcoded UUID map for CONFIG_LIBRARY #9516

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ranj063
Copy link
Collaborator

@ranj063 ranj063 commented Sep 25, 2024

Always append the UUID to the end of the module init IPC data and use that to look up the component driver instead of using the hardcoded UUID map. This will make it easier to support new processing elements with the plugin/testbench.

tools/plugin/alsaplug/tplg.c Show resolved Hide resolved
tools/plugin/alsaplug/tplg.c Show resolved Hide resolved
Copy link
Collaborator

@singalsu singalsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes worked for IPC4 testbench version too. Getting the controls set to work needs more changes but this is sufficient to load and run all components.

tools/plugin/alsaplug/tplg.c Show resolved Hide resolved
Always append the UUID to the end of the module init IPC data and use
that to look up the component driver instead of using the hardcoded UUID
map. This will make it easier to support new processing elements with
the plugin/testbench. Also, modify the get/set_large_config handlers to
use the component driver set in the dev instead of looking it up again.

Signed-off-by: Ranjani Sridharan <[email protected]>
@ranj063
Copy link
Collaborator Author

ranj063 commented Sep 27, 2024

These changes worked for IPC4 testbench version too. Getting the controls set to work needs more changes but this is sufficient to load and run all components.

@singalsu I have updated the patched to also use the already set drv's for the registered components. Could you please check if that helps in your case?

@singalsu
Copy link
Collaborator

These changes worked for IPC4 testbench version too. Getting the controls set to work needs more changes but this is sufficient to load and run all components.

@singalsu I have updated the patched to also use the already set drv's for the registered components. Could you please check if that helps in your case?

Yes, everything works now with this version. Thanks a lot!

@singalsu singalsu requested a review from lyakh September 27, 2024 09:14
@singalsu
Copy link
Collaborator

The cmocka and testbench fails happen also with git main, it's not due to this PR. My own run of those tests with this patch and earlier SOF version worked.

@kv2019i
Copy link
Collaborator

kv2019i commented Sep 30, 2024

I guess cmocka tests fail due to #9518 ..? Otherwise looks good to go.

Copy link
Member

@cujomalainey cujomalainey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge upgrade! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants