add environment identifier #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also add CI for automatically testing schema and examples Signed-off-by: Thomas Fossati <[email protected]>
thomas-fossati
referenced
this pull request
Jan 22, 2024
Xynnn007
reviewed
Jan 24, 2024
| @@ -32,7 +32,7 @@ claim-id = text / int | |||
|
|
|||
| ```cddl | |||
| RV = { | |||
| ? desc: text | |||
| ? environment-id: any | |||
There was a problem hiding this comment.
I think there are some tradeoffs. To me any could improve the flexibility. However, usually environment-id is used as a key to index the RV so text might be better.
There was a problem hiding this comment.
Sure, I just set it to any out of pure laziness. This needs some refinement, with text as an obvious candidate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also add CI for automatically testing schema and examples