UniversalPayload: Add serial and graphic parse in pci-rb node which is non-compatible to 'pci-rb' property #6239
+34
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serial port and Graphic device nodes will be parsed only when 'pci-rb' node is compatible to 'pci-rb' type in current logic, this logic limits bootloader to provide informations of all Host PCI Root Bridges. However, PciHostBridgeLib library in UefiPayloadPkg provides support to scan Host PCI Root Bridges dynamically. Bootloader can utilizes Root Bridges scanning feature, and provides Serial Port and Graphic device information in a 'pci-rb' node without providing informations about all Host PCI Root Bridges. Signed-off-by: Ajan Zhong <[email protected]>
Add Red/Green/Blue mask and pixelsperscanline properties parsing when constructing GraphicInfo HoB, these properties are required during flash Framebuffer data to Graphic device. Signed-off-by: Ajan Zhong <[email protected]>
tianocore-assign-reviewers
bot
requested review from
gdong1,
gguo11837463,
jameslu8 and
Sean-StarLabs
|
@AjanZhong For the graphic part: would you mind to create a PR at the UPL spec as well? The changes have to be alligned to the spec. |
@LeanSheng Appreciate for your response and guide, patch for UPL SPEC has been submitted: UniversalPayload/spec#17, please help review when you are available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Serial port and Graphic device nodes are sub nodes of PCI Root Bridge node, they will be parsed only when 'pci-rb'
node is compatible to 'pci-rb' type in current logic. Add support to parse both Serial device and Graphic device node
and utilize Host PCI Root Bridge scanning feature in pci-rb node which does not compatible to 'pci-rb' property type.
Also we need to parse more options for GOP to ensure framebuffer can be flashed to Graphic device correctly
How This Was Tested
Validated with x86 kernel with FB_EFI/DRM_BOCHS configurations enabled on top QEMU environment.
Integration Instructions
N/A