Recommend not using legible identities. Fixes #1308 #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Fixed
…On Mon, Jul 10, 2023 at 7:56 AM Hubert Kario ***@***.***> wrote:
s/Hello Encrypted Client Hello/Encrypted Client Hello/ ?
—
Reply to this email directly, view it on GitHub
<#1325 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIPLIONUT7PR5XKZIKQKALXPQJ3TANCNFSM6AAAAAA2ETUDZM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Doesn't look like the "Hello Encrypted Client Hello" thing is fixed. Maybe just not pushed? |
chris-wood
reviewed
Jul 13, 2023
richsalz
reviewed
Jul 13, 2023
martinthomson
approved these changes
Jul 17, 2023
kaduk
reviewed
Jul 27, 2023
| @@ -5327,6 +5327,15 @@ Clients and Servers SHOULD NOT reuse a key share for multiple connections. Reuse | |||
| of a key share allows passive observers to correlate different connections. Reuse | |||
| of a client key share to the same server additionally allows the server to correlate different connections. | |||
|
|
|||
| It is RECOMMENDED that the labels for external identities be selected so that they | |||
There was a problem hiding this comment.
FWIW, the actual protocol element is the "identity", which we describe as "a label for a key. For instance...a label for a pre-shared key established externally". We do use the phrasing "PSK identity" in the subsequent paragraph, so maybe "the identities used to identify (label) externally shared keys" if we want to increase consistency?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.