-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Методы в Configurer [WIP] #184
Open
kverty
wants to merge
13
commits into
trikset:master
Choose a base branch
from
kverty:newMethods
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
один для генерации нового файла конфигурации модели другой для изменения параметра модели
плюс возвращение методов
Current coverage is 33.59% (diff: 16.66%)@@ master #184 diff @@
==========================================
Files 165 165
Lines 4084 4147 +63
Methods 784 786 +2
Messages 0 0
Branches 0 0
==========================================
+ Hits 1384 1393 +9
- Misses 2700 2754 +54
Partials 0 0
|
trikKernel/src/configurer.cpp
Outdated
{ | ||
QString content = ""; | ||
QString indent = " "; | ||
content += "<config version = \"" + version() + "\">" + '\n'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
лучше сразу QString content = ...
и добавлены исключения
@yurii-litvinov Review, please. |
iakov
force-pushed
the
master
branch
2 times, most recently
from
August 23, 2018 16:11
e58aa40
to
1c507e2
Compare
iakov
force-pushed
the
master
branch
2 times, most recently
from
November 21, 2018 22:12
8ee914a
to
1a6c3e4
Compare
iakov
force-pushed
the
master
branch
2 times, most recently
from
November 29, 2018 08:37
47800d8
to
5d7f028
Compare
iakov
force-pushed
the
master
branch
16 times, most recently
from
November 29, 2018 16:17
521d224
to
df70e74
Compare
iakov
force-pushed
the
master
branch
2 times, most recently
from
January 12, 2019 14:01
977fb9a
to
cd7baa8
Compare
iakov
force-pushed
the
master
branch
2 times, most recently
from
November 19, 2023 17:26
d1d317e
to
0a4ad77
Compare
iakov
force-pushed
the
master
branch
3 times, most recently
from
August 12, 2024 14:59
b3c87b7
to
165068c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
добавлены два метода
один для генерации нового файла конфигурации модели
другой для изменения параметра модели