fix: usage of ReadDataFromJson in array tensors #7624
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
The
generate
andgenerate_stream
endpoints did not seem to work when directly querying TRTLLM backend with input tokens. This is because theHTTPAPIServer::GenerateRequestClass::ExactMappingInput
does not send the correct size of an array input toReadDataFromJson
.This PR also fixes triton-inference-server/tensorrtllm_backend#369
Checklist
Agreement
<commit_type>: <Title>
pre-commit install, pre-commit run --all
)Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Where should the reviewer start?
Test plan:
Added a new test case to
L0_http
job.Internal CI pipeline id: 18800660
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)