fix: task generateJnlp releases file handles

Closes #52
tschulte · Oct 18, 2017 · c846b3c · c846b3c
1 parent 76fd5d2
commit c846b3c
Showing 1 changed file with 23 additions and 18 deletions.
diff --git a/gradle-jnlp-plugin/src/main/groovy/de/gliderpilot/gradle/jnlp/JnlpTask.groovy b/gradle-jnlp-plugin/src/main/groovy/de/gliderpilot/gradle/jnlp/JnlpTask.groovy
@@ -39,24 +39,26 @@ class JnlpTask extends DefaultTask {
     void generateJnlp() {
         def outputFile = jnlpFile
         outputFile.parentFile.eachFileMatch(~/.*\.jnlp/) { it.delete() }
-        MarkupBuilder xml = new MarkupBuilder(outputFile.newPrintWriter('UTF-8'))
-        xml.mkp.xmlDeclaration(version: '1.0', encoding: 'UTF-8')
-        xml.jnlp(project.jnlp.jnlpParams) {
-            delegate.with project.jnlp.withXmlClosure
-            resources {
-                j2se(project.jnlp.j2seParams)
-                from.resolve().findAll { it.name.endsWith('.jar') }.each { File jarFile ->
-                    jar(jarParams(jarFile))
-                }
+        outputFile.withPrintWriter("UTF-8") { printWriter ->
+            MarkupBuilder xml = new MarkupBuilder(printWriter)
+            xml.mkp.xmlDeclaration(version: '1.0', encoding: 'UTF-8')
+            xml.jnlp(project.jnlp.jnlpParams) {
+                delegate.with project.jnlp.withXmlClosure
+                resources {
+                    j2se(project.jnlp.j2seParams)
+                    from.resolve().findAll { it.name.endsWith('.jar') }.each { File jarFile ->
+                        jar(jarParams(jarFile))
+                    }
 
-                // see http://docs.oracle.com/javase/tutorial/deployment/deploymentInDepth/avoidingUnnecessaryUpdateChecks.html
-                if (project.jnlp.useVersions)
-                    property name: 'jnlp.versionEnabled', value: 'true'
-                // see http://docs.oracle.com/javase/tutorial/deployment/deploymentInDepth/reducingDownloadTime.html
-                if (project.jnlp.usePack200)
-                    property name: 'jnlp.packEnabled', value: 'true'
+                    // see http://docs.oracle.com/javase/tutorial/deployment/deploymentInDepth/avoidingUnnecessaryUpdateChecks.html
+                    if (project.jnlp.useVersions)
+                        property name: 'jnlp.versionEnabled', value: 'true'
+                    // see http://docs.oracle.com/javase/tutorial/deployment/deploymentInDepth/reducingDownloadTime.html
+                    if (project.jnlp.usePack200)
+                        property name: 'jnlp.packEnabled', value: 'true'
+                }
+                delegate.with project.jnlp.desc
             }
-            delegate.with project.jnlp.desc
         }
     }
 
@@ -84,7 +86,10 @@ class JnlpTask extends DefaultTask {
     }
 
     boolean containsMainClass(File file) {
-        if (project.jnlp.mainClassName)
-            new JarFile(file).getEntry(project.jnlp.mainClassName.replace('.', '/') + '.class')
+        if (project.jnlp.mainClassName) {
+            new JarFile(file).withCloseable {
+                it.getEntry(project.jnlp.mainClassName.replace('.', '/') + '.class')
+            }
+        }
     }
 }