Support Qt6 on MacOS #589
Support Qt6 on MacOS #589
Conversation
|
To begin with, if I open two Featherpad instances at once, the second one alarms me that the previous one crashed (even if it didn't) |
|
In fact, when I did installation I was kind of dumb. I wanted it to be a macOS-like app. Maybe I should rework that to be unix-like app somewhere in /usr/local/ in a separate pull request. Installation works, but it is screwed not to install icons and help files. Also, it cannot find Qt on my system since it is not in library path. |
|
WAT |
|
|
|
Print dialog untranslated |
|
I manually disabled "system file dialog" and now it opens Qt file dialog. But I am 99% sure macOS system dialog worked well previously |
|
@tsujan I think you can merge it now squashing all commits in one. As for the bugs described above, I think it's better to discuss and address them one by one in separate pull requests |
| ${Qt5Network_INCLUDE_DIRS} | ||
| ${Qt5PrintSupport_INCLUDE_DIRS} | ||
| ${HUNSPELL_INCLUDE_DIRS}) | ||
| if(QT_VERSION_MAJOR EQUAL 6) |
There was a problem hiding this comment.
Oh, how did I miss these?! Perhaps because I was tired last night.
You could use Qt${QT_VERSION_MAJOR}... here (like ${Qt${QT_VERSION_MAJOR}Core_INCLUDE_DIRS} and the same for others) because they're basically the same for Qt5 and Qt6. In other places, I separated them from each other because some include dirs weren't common.
And the same for the other block...
Would you please do it?
|
I merge your PR — it fixes a bad mistake of mine — and make those changes later. Thanks a lot! |
Hello!
Since Qt6 build is not supported on MacOS, I decided to make this pull request. It has been tested only with make on m1 Mac running macOS Montery and it has some issues. I'll try to resolve them and then it will be ready for merge