Dependency updates and some cleanups #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Two problems:
|
|
Looking at compilation times of individual modules, all modules compile within seconds, except these:
And the common thing among these modules is that they use deriving-aeson to derive JSON instances for a lot of data types. Safe to say, that package is causing the slowdown with this PR. I'll continue investigating. |
|
Here's the full log of a compilation with |
|
The performance problem doesn't appear to be related to haskell.nix, because it's the same even when I tried to switch to the nixpkgs Haskell infrastructure, see https://github.com/tweag/webauthn/tree/nixpkgs-haskell |
|
Turns out that the problem only appears with |
|
I reported the performance problem in fumieval/deriving-aeson#16, having created a reproducible minimal example in https://github.com/tweag/webauthn/tree/deriving-aeson-slow-repro |
infinisil
force-pushed
the
dep-updates
branch
2 times, most recently
from
4f5cbbf
to
ef37088
Compare
|
I fixed the bash problem on macOS by just not using This seems to be the same as issue NixOS/nix#5125 |
|
Since this seems to be related to import-from-derivation, and I already did the work of getting the nixpkgs haskell infra to work in https://github.com/tweag/webauthn/tree/nixpkgs-haskell, I'm just gonna switch to that. This will also speed up CI and nix-shells |
We want to use cryptograhically secure randomness, which the random library isn't intended for. Instead we're going to use cryptonite's `MonadRandom` which is. Also gets rid of a direct dependency.
We really don't need much from it
infinisil
force-pushed
the
dep-updates
branch
3 times, most recently
from
ed7ea2d
to
bcd6b8c
Compare
haskell.nix caused problems on darwin due to a segfaults after updating haskell.nix, see NixOS/nix#5125 This commit also cleans up CI a bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for changes