Skip to content

Commit

Permalink
Move tcheck to go.mod, get rid of glide dependency (#3999)
Browse files Browse the repository at this point in the history
[glide.sh is down](Masterminds/glide#1077), breaking our pipelines, and glide is abandonware anyway.
It's well past time to migrate off.

I don't believe `tcheck` is actually used for anything, nor is it mentioned in any documentation... but it _does_ work, it'll tell you if e.g. cadence-frontend is running and could be useful for scripting.  Though in that case a relevant `cadence ...` command would be as good or better anyway.

It may be worth removing this entirely?  It's not particularly large nor pulling in any new dependencies, but it may just be old cruft.
  • Loading branch information
Groxx authored and longquanzheng committed Mar 1, 2021
1 parent 6156abf commit b6dfe37
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 15 deletions.
17 changes: 2 additions & 15 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,23 +6,10 @@ ARG GOPROXY
# Build tcheck binary
FROM golang:1.13.6-alpine AS tcheck

RUN apk add --update --no-cache ca-certificates git curl

ENV GO111MODULE=off

RUN curl https://glide.sh/get | sh

ENV TCHECK_VERSION=v1.1.0

RUN go get -d github.com/uber/tcheck
RUN cd /go/src/github.com/uber/tcheck && git checkout ${TCHECK_VERSION}

WORKDIR /go/src/github.com/uber/tcheck

RUN glide install

RUN go install

COPY go.* ./
RUN go build -mod=readonly -o /go/bin/tcheck github.com/uber/tcheck

# Build Cadence binaries
FROM golang:1.13.6-alpine AS builder
Expand Down
7 changes: 7 additions & 0 deletions cmd/server/tools.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,11 @@ import (
_ "github.com/golang/mock/mockgen"
// enumer for generating utility methods for const enums
_ "github.com/dmarkham/enumer"
// replaces golint - configurable and much faster
_ "github.com/mgechev/revive"
// coverage reporting
_ "github.com/dmetzgar/goveralls"

// health check for docker containers
_ "github.com/uber/tcheck"
)
1 change: 1 addition & 0 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ require (
github.com/uber-go/tally v3.3.15+incompatible
github.com/uber/ringpop-go v0.8.5
github.com/uber/tchannel-go v1.16.0
github.com/uber/tcheck v1.1.0
github.com/urfave/cli v1.22.4
github.com/valyala/fastjson v1.4.1
github.com/xdg/scram v0.0.0-20180814205039-7eeb5667e42c
Expand Down
2 changes: 2 additions & 0 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,8 @@ github.com/uber/ringpop-go v0.8.5/go.mod h1:zVI6eGO6L7pG14GkntHsSOfmUAWQ7B4lvmzl
github.com/uber/tchannel-go v1.14.0/go.mod h1:Rrgz1eL8kMjW/nEzZos0t+Heq0O4LhnUJVA32OvWKHo=
github.com/uber/tchannel-go v1.16.0 h1:B7dirDs15/vJJYDeoHpv3xaEUjuRZ38Rvt1qq9g7pSo=
github.com/uber/tchannel-go v1.16.0/go.mod h1:Rrgz1eL8kMjW/nEzZos0t+Heq0O4LhnUJVA32OvWKHo=
github.com/uber/tcheck v1.1.0 h1:Sf5jbtsSg03DZNe8vECLPtFCflAJVg/IYwIxyM9qL/o=
github.com/uber/tcheck v1.1.0/go.mod h1:ytWRjtMoI4Rb/0aZxYeLQHhGyv3uxJk8UR39lq5RqNc=
github.com/urfave/cli v1.22.4 h1:u7tSpNPPswAFymm8IehJhy4uJMlUuU/GmqSkvJ1InXA=
github.com/urfave/cli v1.22.4/go.mod h1:Gos4lmkARVdJ6EkW0WaNv/tZAAMe9V7XWyB60NtXRu0=
github.com/valyala/fastjson v1.4.1 h1:hrltpHpIpkaxll8QltMU8c3QZ5+qIiCL8yKqPFJI/yE=
Expand Down

0 comments on commit b6dfe37

Please sign in to comment.