remove roles to merge training role rules with training tag rules #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cat-bro
changed the title
nuwang
previously approved these changes
Aug 2, 2024
| include_tags = ['pulsar'] | ||
| exclude_tags = ['pulsar-training-large', 'training-exempt'] | ||
| slurm_preferred_for_training = pulsar_score is not None and pulsar_score < pulsar_score_slurm_threshold | ||
| training_job_matches_specs = (not slurm_preferred_for_training) and helpers.tag_values_match(entity, include_tags, exclude_tags) |
There was a problem hiding this comment.
Since only this line is different between slurm and pulsar, maybe it would make sense to move this code to a seperate file that we just import. A possible future enhancement. I imagine more scenarios like this will pile up.
There was a problem hiding this comment.
I agree - most of the code in the 3 blocks is identical.
cat-bro
force-pushed
the
remove_roles_to_merge_training_role_rules_with_training_tag_rules
branch
from
e2fb865
to
eccf27b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consideration: The aim is that somebody could add the tag 'training' to their history and get the same treatment as somebody in a training group, which could be useful for testing a tutorial ahead of time.
For issue #1942