Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FactionsUUID support (#182) #189

Merged
merged 4 commits into from
Jan 9, 2022
Merged

Add FactionsUUID support (#182) #189

merged 4 commits into from
Jan 9, 2022

Conversation

utarwyn
Copy link
Owner

@utarwyn utarwyn commented Jan 8, 2022

Description

Resolves #182

Changes

  • Added a new dependency module called "factionsuuid" which handles Factions v1.6.9.5-U0.6.6 by @mbax.

    So there are 3 modules for Factions plugins: factions1 (legacy), factions2 and factionsuuid.

  • Improved DependencyResolver to also match plugin authors if provided.
  • Registered new "factionsuuid" dependency module in the manager.

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.

@utarwyn utarwyn added bug: confirmed Confirmed bugs in EnderContainers. status: testing Issues or PRs that need to be tested in order to be resolved. dependencies This issue or pull request concerns a dependency labels Jan 8, 2022
@utarwyn utarwyn added this to the v2.2.x milestone Jan 8, 2022
@utarwyn utarwyn self-assigned this Jan 8, 2022
@utarwyn utarwyn force-pushed the issue-182-factionsuuid-support branch from 6beb678 to d24b04c Compare January 8, 2022 21:42
@sonarcloud
Copy link

sonarcloud bot commented Jan 8, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

72.9% 72.9% Coverage
0.0% 0.0% Duplication

@utarwyn
Copy link
Owner Author

utarwyn commented Jan 8, 2022

If someone wants to help me testing the new integration with FactionsUUID, you can download latest development build by clicking here. Note that this build will be destroyed after PR merging.

@utarwyn
Copy link
Owner Author

utarwyn commented Jan 9, 2022

I would like to thank illudota who tested the addition. Everything seems to work fine, so I'm merging the PR.
This will be available in v2.2.3. 🚀

@utarwyn utarwyn merged commit ce2aeab into master Jan 9, 2022
@utarwyn utarwyn deleted the issue-182-factionsuuid-support branch January 9, 2022 17:16
@utarwyn utarwyn linked an issue Jan 9, 2022 that may be closed by this pull request
FactionsUUID support broken by updates #182
Open
@utarwyn utarwyn mentioned this pull request Jul 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbax mbax mbax left review comments

Assignees

@utarwyn utarwyn

Labels
bug: confirmed Confirmed bugs in EnderContainers. dependencies This issue or pull request concerns a dependency status: testing Issues or PRs that need to be tested in order to be resolved.
Projects
None yet
Milestone
v2.2.x
Development

Successfully merging this pull request may close these issues.

FactionsUUID support broken by updates
2 participants
@utarwyn @mbax