Skip to content
This repository has been archived by the owner on Apr 27, 2024. It is now read-only.

Track progress #3

Closed
68 tasks done
rubiin opened this issue May 26, 2020 · 21 comments
Closed
68 tasks done

Track progress #3

rubiin opened this issue May 26, 2020 · 21 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Progress
Milestone

Comments

@rubiin
Copy link
Member

rubiin commented May 26, 2020

This is used to track all the validators that has been ported successfully . Feel free to send in any PR which ports the validators which are not ticked below

  • isAfter
  • isAlpha
  • isAlphanumeric
  • isAscii
  • isBIC
  • isBase32
  • isBase64
  • isBefore
  • isBoolean
  • isBtcAddress
  • isByteLength
  • isCreditCard
  • isCurrency
  • isDataURI
  • isDate
  • isDecimal
  • isDivisibleBy
  • isEAN
  • isEmail
  • isEmpty
  • isEthereumAddress
  • isFQDN
  • isFloat
  • isFullWidth
  • isHSL
  • isHalfWidth
  • isHash
  • isHexColor
  • isHexadecimal
  • isIBAN
  • isIP
  • isIPRange
  • isISBN
  • isISIN
  • isISO31661Alpha2
  • isISO31661Alpha3
  • isISO8601
  • isISRC
  • isISSN
  • isIdentityCard
  • isIn
  • isInt
  • isJSON
  • isJWT
  • isLatLong
  • isLocale
  • isLowercase
  • isMACAddress
  • isMagnetURI
  • isMimeType
  • isMobilePhone
  • isMongoId
  • isMultibyte
  • isNumeric
  • isOctal
  • isPassportNumber
  • isPort
  • isPostalCode
  • isRFC3339
  • isRgbColor
  • isSemVer
  • isSlug
  • isSurrogatePair
  • isURL
  • isUUID
  • isUppercase
  • isVariableWidth
  • isWhitelisted

Won't work on

  • isLength (deprecated)
  • isMD5 (won't include)
@rubiin rubiin added documentation Improvements or additions to documentation Progress labels May 26, 2020
@rubiin rubiin added this to the version 1.0.0 milestone May 26, 2020
@rubiin
Copy link
Member Author

rubiin commented May 26, 2020

@parasg1999 pick the undone validators from here

@parasg1999
Copy link
Collaborator

@rubiin Sure! Will do. Was working on improving the test template.

@rubiin rubiin added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels May 26, 2020
@parasg1999
Copy link
Collaborator

parasg1999 commented May 27, 2020

I think we should remove isMD5, since isHash can be used with md5 as the second argument.
Also we are not trying to make it backwards compatible.

@rubiin
Copy link
Member Author

rubiin commented May 27, 2020

I think we should remove isMD5, since isHash can be used with md5 as the second argument.
Also we are not trying to make it backwards compatible.

sure. Also we need to import any bug fixes from validator.js after we have ported the lib

@parasg1999 parasg1999 pinned this issue May 28, 2020
@RishabAgarwal
Copy link

Hey, can I also work on this??

@rubiin
Copy link
Member Author

rubiin commented May 28, 2020

@RishabAgarwal sure.

@rubiin
Copy link
Member Author

rubiin commented May 28, 2020

@parasg1999 lets speed up things as only 14 extra validators are needed to complete the lib

@RishabAgarwal
Copy link

Thanks @rubiin. I started working on isDivisibleBy. I was wonder if (1.2, 0.2) should return true or false?
Validator for nodejs returns false but in actual it is divisible.

@parasg1999
Copy link
Collaborator

parasg1999 commented May 28, 2020

Thanks @rubiin. I started working on isDivisibleBy. I was wonder if (1.2, 0.2) should return true or false?
Validator for nodejs returns false but in actual it is divisible.

@RishabAgarwal validator.js only works for integers, we can include the support for float as well, but we need to pay attention to the precision errors.
What do you say @rubiin

@RishabAgarwal
Copy link

I created a PR for isDivisibleBy. I think we can add that later on.

@RishabAgarwal
Copy link

Hey, so should just add more validator to the master branch, the same PR #21 or create a new branch and a PR for every new validator??

@rubiin
Copy link
Member Author

rubiin commented May 29, 2020

@RishabAgarwal you can do either way

@RishabAgarwal
Copy link

I'll take isURL if no is doing it.

@rubiin
Copy link
Member Author

rubiin commented May 29, 2020

sure

@RishabAgarwal
Copy link

I'll take up isEmail if no one is doing it

@parasg1999
Copy link
Collaborator

Go ahead! @RishabAgarwal

@rubiin
Copy link
Member Author

rubiin commented May 29, 2020

@RishabAgarwal @parasg1999 lets work on documentation now

@RishabAgarwal
Copy link

Yeah sure. How do you wanna distribute it @rubiin

@rubiin
Copy link
Member Author

rubiin commented May 29, 2020

@RishabAgarwal you can do any and as much you like. theres no restrictions

@RishabAgarwal
Copy link

RishabAgarwal commented May 29, 2020

@rubiin I'll get on it. Can you also add a check box list to the document issue too. So we can keep track of all the validator whose documentation is done.

@parasg1999
Copy link
Collaborator

@RishabAgarwal I have added that.

@rubiin rubiin closed this as completed Jan 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Progress
Projects
None yet
Development

No branches or pull requests

3 participants