Skip to content
This repository has been archived by the owner on Apr 27, 2024. It is now read-only.

Added isUrl validator #24

Merged
merged 2 commits into from
May 29, 2020
Merged

Added isUrl validator #24

merged 2 commits into from
May 29, 2020

Conversation

RishabAgarwal
Copy link

@RishabAgarwal RishabAgarwal commented May 29, 2020 •
edited
Loading

isURL #3

parasg1999
parasg1999 suggested changes May 29, 2020
View reviewed changes
src/lib/isURL.ts
}

const default_url_options: isURLOptins = {
protocols: ["http", "https", "ftp"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix this to defaultURLOptions, and isURLOptions

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@parasg1999 parasg1999 added 🧹 needs-update For PRs that need to be updated before landing enhancement New feature or request labels May 29, 2020
@parasg1999
Copy link
Collaborator

parasg1999 commented May 29, 2020 •
edited
Loading

LGTM. Thanks for the contribution :)

@parasg1999 parasg1999 merged commit d6ee87e into validatorjs:master May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@parasg1999 parasg1999 parasg1999 approved these changes

Assignees
No one assigned
Labels
🧹 needs-update For PRs that need to be updated before landing enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RishabAgarwal @parasg1999