Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update all tooling #2401

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: update all tooling #2401

wants to merge 4 commits into from

Conversation

rubiin
Copy link
Member

@rubiin rubiin commented May 10, 2024

Updates all tools (expect mocha and nyc)
Also has the files linted (was not linted before thus many file changes )

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@rubiin rubiin requested review from profnandaa and WikiRik May 10, 2024 15:34
@rubiin
Copy link
Member Author

rubiin commented May 10, 2024

I think this fixes things @profnandaa . We can do a beta release for this

src/lib/alpha.js Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
Copy link
Member

@WikiRik WikiRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a breaking change since we drop support for Node <18. So we'll need to keep that in mind when merging

@WikiRik WikiRik mentioned this pull request Jun 5, 2024
4 tasks
@pano9000
Copy link
Contributor

just a quick observation: the biggest chunk of changes here seem to be style changes -> is there a reason for that?
I assume it has to do with linting?
But shouldn't the rules have stayed the same, if this is only about updating the tooling versions?

@rubiin
Copy link
Member Author

rubiin commented Aug 25, 2024

just a quick observation: the biggest chunk of changes here seem to be style changes -> is there a reason for that? I assume it has to do with linting? But shouldn't the rules have stayed the same, if this is only about updating the tooling versions?

I could reroll the style changes but those are from eslint fix.

@WikiRik
Copy link
Member

WikiRik commented Aug 25, 2024

But shouldn't the rules have stayed the same, if this is only about updating the tooling versions?

Not 100% sure, but default configuration can change over minor versions and it might be due to a case that wasn't discovered in earlier versions but is now. If we want to not have those changes we can update the configuration manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants