feat(isMobilePhone): update phone regex for Cameroon fr-CM #2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubiin
approved these changes
Sep 17, 2024
WikiRik
requested changes
Oct 1, 2024
| @@ -100,7 +100,7 @@ const phones = { | |||
| 'fr-BF': /^(\+226|0)[67]\d{7}$/, | |||
| 'fr-BJ': /^(\+229)\d{8}$/, | |||
| 'fr-CD': /^(\+?243|0)?(8|9)\d{8}$/, | |||
| 'fr-CM': /^(\+?237)6[0-9]{8}$/, | |||
| 'fr-CM': /^(\+?237)(6|2)[0-9]{8}$/, | |||
There was a problem hiding this comment.
This change is not needed as far as I can see. A number starting with 2 is not for mobile phone numbers, only fixed numbers (which we don't validate here). We can improve this regular expression to make it more strict though.
The latest ITU information (which is my primary source) is from 2014, so it might be outdated;
https://www.itu.int/oth/T0202000024/en
There was a problem hiding this comment.
I had some work done for a client with a modem who's number started with 2. The modem uses LTE for connectivity so would that be a fixed or mobile classification?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update phone regex to match both mobile and fix IDS numbers for Cameroon fr-CM
Checklist
Read more