Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managed platform #3

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Conversation

jasinner
Copy link
Member

Managed Platform requires images to be based on RHEL 7, so we can't use the Dockerfile included in victims-web. This repo will now clone victims-web master branch when building the docker image, and use s2i to build it on top of rhscl/python-27-rhel7. It will override some of the configuration options in config.py, with the victimconfig.py ones in this repository.

All the legacy, Openshift 2 stuff has been removed.

Copy link
Member

@ashcrow ashcrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Few questions/notes...

.gitignore Outdated
.mr.developer.cfg
.project
.pydevproject
.idea/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did the traditional python ignore files get removed?

```sh
rhc app create victims mongodb-2.2 rockmongo-1.1 python-2.7 --from-code git://github.com/victims/victims-server-openshift.git
oc login https://console.starter-us-east-1.openshift.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably say https://youropenshiftinstance.example.com or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants