Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue where live dash streams without audio would hang #1524

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

mwaltza
Copy link
Contributor

@mwaltza mwaltza commented Jul 3, 2024

Description

Fixes this issue: #1471
Tested with this endpoint: https://livesim2.dashif.org/livesim2/segtimeline_1/WAVE/vectors/cfhd_sets/12.5_25_50/t1/2022-10-17/stream.mpd

  • before the fix, this endpoint hangs after a few seconds
  • after, this endpoint continues to play live video

Specific Changes proposed

Check whether media group is undefined before checking its contents

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

Copy link

welcome bot commented Jul 3, 2024

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.36%. Comparing base (7083c5e) to head (6f69756).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1524      +/-   ##
==========================================
- Coverage   86.40%   86.36%   -0.04%     
==========================================
  Files          43       43              
  Lines       11144    11144              
  Branches     2545     2545              
==========================================
- Hits         9629     9625       -4     
- Misses       1515     1519       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mister-ben mister-ben merged commit 1ecf115 into videojs:main Aug 23, 2024
6 of 7 checks passed
Copy link

welcome bot commented Aug 23, 2024

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants