Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow vtt rollover with MPEGTS of 0 #1537

Merged
merged 1 commit into from
Aug 30, 2024
Merged

fix: allow vtt rollover with MPEGTS of 0 #1537

merged 1 commit into from
Aug 30, 2024

Conversation

adrums86
Copy link
Contributor

@adrums86 adrums86 commented Aug 29, 2024

Description

Allow handleRollover to be called on vtt segments when the MPEGTS value from the X-TIMESTAMP-MAP tag is 0

Specific Changes proposed

Remove the MPEGTS === 0 check and associated ternary.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.36%. Comparing base (11a159e) to head (8b13af4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1537      +/-   ##
==========================================
- Coverage   86.36%   86.36%   -0.01%     
==========================================
  Files          43       43              
  Lines       11151    11149       -2     
  Branches     2548     2546       -2     
==========================================
- Hits         9631     9629       -2     
  Misses       1520     1520              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrums86 adrums86 marked this pull request as ready for review August 29, 2024 20:41
@adrums86 adrums86 merged commit 2125ecf into main Aug 30, 2024
12 checks passed
@adrums86 adrums86 deleted the fix-vtt-rollover branch August 30, 2024 20:44
adrums86 added a commit to videojs/video.js that referenced this pull request Sep 10, 2024
## Description
Update VHS to v3.14.1 for a VTT timing fix detailed here:
videojs/http-streaming#1537

## Specific Changes proposed
Update the VHS package to v.3.14.1.

## Requirements Checklist
- [x] Feature implemented / Bug fixed
- [ ] If necessary, more likely in a feature request than a bug fix
- [ ] Change has been verified in an actual browser (Chrome, Firefox,
IE)
  - [ ] Unit Tests updated or fixed
  - [ ] Docs/guides updated
- [ ] Example created ([starter template on
JSBin](https://codepen.io/gkatsev/pen/GwZegv?editors=1000#0))
- [ ] Has no DOM changes which impact accessiblilty or trigger warnings
(e.g. Chrome issues tab)
  - [ ] Has no changes to JSDoc which cause `npm run docs:api` to error
- [ ] Reviewed by Two Core Contributors

---------

Co-authored-by: Essk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants