Fix sidebar state persistence (#4745)

* lint graphQLSyncFragmentAtomFamily * rm unused exposed function, add on set for grid sidebar * fix sidebar persitence * add expansion inheritance
voxel51 · Aug 29, 2024 · dbdda14 · dbdda14
1 parent 48eaa46
commit dbdda14
Show file tree

Hide file tree

Showing 9 changed files with 94 additions and 75 deletions.
diff --git a/app/packages/app/src/pages/datasets/__generated__/DatasetPageQuery.graphql.ts b/app/packages/app/src/pages/datasets/__generated__/DatasetPageQuery.graphql.ts
diff --git a/app/packages/relay/src/fragments/__generated__/sidebarGroupsFragment.graphql.ts b/app/packages/relay/src/fragments/__generated__/sidebarGroupsFragment.graphql.ts
diff --git a/app/packages/relay/src/fragments/sidebarGroupsFragment.ts b/app/packages/relay/src/fragments/sidebarGroupsFragment.ts
@@ -2,7 +2,7 @@ import { graphql } from "relay-runtime";
 
 export default graphql`
   fragment sidebarGroupsFragment on Dataset {
-    name
+    datasetId
     appConfig {
       sidebarGroups {
         expanded

diff --git a/app/packages/relay/src/graphQLSyncFragmentAtomFamily.ts b/app/packages/relay/src/graphQLSyncFragmentAtomFamily.ts
@@ -56,8 +56,8 @@ export function graphQLSyncFragmentAtomFamily<
         !fragmentOptions.sync || fragmentOptions.sync(params)
           ? [
               ({ setSelf, trigger }: Parameters<AtomEffect<K>>[0]) => {
-                // recoil state should be initialized via RecoilRoot's initializeState
-                // during tests
+                // recoil state should be initialized via RecoilRoot's
+                // initializeState during tests
                 if (isTest) return;
 
                 if (trigger === "set") {
@@ -94,7 +94,7 @@ export function graphQLSyncFragmentAtomFamily<
                   try {
                     for (let i = 0; i < fragmentOptions.fragments.length; i++) {
                       const fragment = fragmentOptions.fragments[i];
-                      if (fragmentOptions.keys && fragmentOptions.keys[i]) {
+                      if (fragmentOptions?.keys[i]) {
                         // @ts-ignore
                         data = data[fragmentOptions.keys[i]];
                       }