Skip to content

Commit

Permalink
Merge pull request #311 from bastelfreak/strict
Browse files Browse the repository at this point in the history
CI: Build gem with --strict --verbose & add version contraints to dependencies
  • Loading branch information
bastelfreak authored May 13, 2024
2 parents c0997ae + 61f859f commit f54b33d
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
env:
BUNDLE_WITHOUT: release
- name: Build gem
run: gem build *.gemspec
run: gem build --strict --verbose *.gemspec
- name: Publish gem to rubygems.org
run: gem push *.gem
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
- name: Run tests
run: bundle exec rake spec
- name: Build gem
run: gem build *.gemspec
run: gem build --strict --verbose *.gemspec

tests:
needs:
Expand Down
9 changes: 4 additions & 5 deletions facterdb.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,11 @@ Gem::Specification.new do |s|
# we have that configured in our CI file
s.required_ruby_version = Gem::Requirement.new('>= 2.7.0')

s.add_development_dependency 'coveralls'
s.add_development_dependency 'pry'
s.add_development_dependency 'rake'
s.add_development_dependency 'rspec'
s.add_development_dependency 'coveralls', '~> 0.8.23'
s.add_development_dependency 'rake', '~> 13.2', '>= 13.2.1'
s.add_development_dependency 'rspec', '~> 3.13'

s.add_development_dependency 'voxpupuli-rubocop', '~> 2.7.0'
s.add_runtime_dependency 'facter', '< 5.0.0'
s.add_runtime_dependency 'jgrep'
s.add_runtime_dependency 'jgrep', '~> 1.5', '>= 1.5.4'
end

0 comments on commit f54b33d

Please sign in to comment.