Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate Redhat 7 facts #307

Closed
wants to merge 2 commits into from
Closed

Regenerate Redhat 7 facts #307

wants to merge 2 commits into from

Conversation

zilchms
Copy link
Contributor

@zilchms zilchms commented Mar 19, 2024

#304 addressed the discrepancy in the IP addresses of redhat 8 (which is important for the unit test failures in puppet-openvpn).
However, we missed the RedHat 7 facts which a) have the wrong IPv4 addresses for some reason (introduced in #257, which probably broke more than just openvpn) and b) we are missing all RedHat 7 facts except for version 4.2

@zilchms
Copy link
Contributor Author

zilchms commented Mar 20, 2024

Todo before merge: Re-add legacy facts as puppet 7 isnt EOL yet

@zilchms
Copy link
Contributor Author

zilchms commented Mar 21, 2024

@yakatz sorry to bother you again... do you happen to know how to include the legacy facts when regenerating with 'undle exec rake rhel_alts'?

@yakatz
Copy link
Contributor

yakatz commented Mar 22, 2024

The script just takes the centos values and does a find/replace for the target os. Since we actually generate rhel facts, it makes more sense to count the rhel facts as authoritative and replace the other way. I submitted a separate PR for that: #303
(Although it assumes rhel 7 support has ended)

@yakatz
Copy link
Contributor

yakatz commented Mar 22, 2024

The script also only looks at x86_64, not 386 facts

@yakatz
Copy link
Contributor

yakatz commented May 20, 2024

@zilchms Can you rebase this?

@zilchms
Copy link
Contributor Author

zilchms commented May 21, 2024

Sure, but I am not sure I finished what I set out to do.

@zilchms zilchms mentioned this pull request May 27, 2024
@zilchms
Copy link
Contributor Author

zilchms commented May 27, 2024

discontinued because: #354 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants