Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[venom]: common subexpression elimination pass #4241

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

HodanPlodky
Copy link
Contributor

What I did

Created common subexpression elimination pass

How I did it

Created available expression analysis and common subexpressions elimination pass. The available expression analysis is done with consideration to effects which heavy inspired by multidimensional fencing.

How to verify it

Created tests

Commit message

feat[venom]: common subexpression elimination

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

class _Expression:
first_inst : IRInstruction
opcode: str
operands : list[IROperand]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this can be IROperand | _Expression

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 27.35426% with 162 lines in your changes missing coverage. Please review.

Project coverage is 45.91%. Comparing base (e21f3e8) to head (a3585ed).

Files with missing lines Patch % Lines
vyper/venom/analysis/available_expression.py 28.65% 117 Missing ⚠️
...r/venom/passes/common_subexpression_elimination.py 23.21% 43 Missing ⚠️
vyper/venom/__init__.py 50.00% 1 Missing ⚠️
vyper/venom/passes/dft.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (e21f3e8) and HEAD (a3585ed). Click for more details.

HEAD has 138 uploads less than BASE
Flag BASE (e21f3e8) HEAD (a3585ed)
139 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4241       +/-   ##
===========================================
- Coverage   91.36%   45.91%   -45.45%     
===========================================
  Files         108      110        +2     
  Lines       15637    15859      +222     
  Branches     3440     3496       +56     
===========================================
- Hits        14287     7282     -7005     
- Misses        920     8024     +7104     
- Partials      430      553      +123     
Flag Coverage Δ
45.91% <27.35%> (-45.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HodanPlodky HodanPlodky marked this pull request as ready for review September 30, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants