Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Substratesnap_Maintenance-2 #517

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Substratesnap_Maintenance-2 #517

merged 1 commit into from
Aug 8, 2022

Conversation

danforbes
Copy link
Contributor

Milestone Delivery Checklist

Link to the application pull request: w3f/Grants-Program#874

@Noc2 Noc2 self-assigned this Jul 29, 2022
Noc2
Noc2 requested changes Aug 4, 2022
View reviewed changes
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the delivery. However, is this for June or july? Delivery number 1 or 2? Since ChainSafe/metamask-snap-polkadot#134 was already part of your previous delivery and the work was done at the beginning of june, see also https://github.com/w3f/Grant-Milestone-Delivery/blob/master/maintenance_evaluations/Substratesnap_Maintenance_1_Noc2.md

@danforbes
Copy link
Contributor Author

Hi, David - I think this would be delivery 2 for June. Delivery number 1 was for May and the invoice for that was submitted by some non-standard mechanism, I believe. Most of the work for ChainSafe/metamask-snap-polkadot#134 was done in June, but it looks like the work was started at the very end of May, which is probably why it was represented on the May delivery as well.
image

Noc2
Noc2 approved these changes Aug 8, 2022
View reviewed changes
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m generally happy to approve the delivery and merge it. But regarding the invoice, weren’t we supposed to get a discount or something because of the previous month? Could you potentially upload an updated invoice?

@Noc2 Noc2 merged commit a100f26 into w3f:master Aug 8, 2022
@danforbes danforbes deleted the dforbes/Substratesnap_Maintenance-2 branch August 8, 2022 15:40
failfmi pushed a commit to LimeChain/Grant-Milestone-Delivery that referenced this pull request Sep 26, 2022
Add PolkaSign (w3f#517)
2b6434a 
* Add application for SubDAO Chrome Extension

Add application for SubDAO Chrome Extension

* Update application according to the comments

Update application according to the comments

* Add examples for features in application

Add examples for features in application

* add PolkaSign

* update addresses and price

* update

* Update SubDAO_PolkaSign.md

* Update Application PR link
* Add Unit Tests
@Noc2
Copy link
Collaborator

Noc2 commented Sep 29, 2022

Just for the records: I will forward the updated invoice internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noc2 Noc2 Noc2 approved these changes

Assignees

@Noc2 Noc2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danforbes @Noc2