7246 drpcprovider #7252
Open
7246 drpcprovider #7252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdevcs
commented
Sep 12, 2024
| const web3 = new Web3(mainnet); | ||
| const result = await web3.eth.getBlockNumber(); | ||
| expect(typeof result).toBe('bigint'); | ||
| expect(result > 0).toBe(true); | ||
| }); | ||
|
|
||
| it(`should work with default provider`, async () => { | ||
| it.skip(`should work with default provider`, async () => { |
There was a problem hiding this comment.
few tests skipped until web3.js specific public key is added in this PR
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: f2f2974 | Previous: b3cb1b7 | Ratio |
|---|---|---|---|
processingTx |
20716 ops/sec (±8.52%) |
21696 ops/sec (±8.85%) |
1.05 |
processingContractDeploy |
35740 ops/sec (±6.91%) |
40328 ops/sec (±6.93%) |
1.13 |
processingContractMethodSend |
14244 ops/sec (±8.80%) |
17416 ops/sec (±6.78%) |
1.22 |
processingContractMethodCall |
26116 ops/sec (±6.69%) |
28028 ops/sec (±7.80%) |
1.07 |
abiEncode |
38581 ops/sec (±9.59%) |
46457 ops/sec (±6.59%) |
1.20 |
abiDecode |
25936 ops/sec (±9.07%) |
31537 ops/sec (±7.34%) |
1.22 |
sign |
1482 ops/sec (±0.90%) |
1584 ops/sec (±0.53%) |
1.07 |
verify |
351 ops/sec (±3.22%) |
364 ops/sec (±2.47%) |
1.04 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7252 +/- ##
=======================================
Coverage 94.44% 94.44%
=======================================
Files 216 216
Lines 8454 8454
Branches 2335 2335
=======================================
Hits 7984 7984
Misses 470 470
Flags with carried forward coverage won't be shown. Click here to find out more. |
jdevcs
requested review from
avkos,
luu-alex and
Muhammad-Altabba
as code owners
avkos
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#7246
#7263
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.