-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct type and documentation for baseFeePerGas
at web3.eth.getFeeHistory
#7291
base: 4.x
Are you sure you want to change the base?
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 960d30e | Previous: cc99825 | Ratio |
---|---|---|---|
processingTx |
22910 ops/sec (±8.32% ) |
21879 ops/sec (±7.68% ) |
0.95 |
processingContractDeploy |
40965 ops/sec (±7.96% ) |
38811 ops/sec (±6.95% ) |
0.95 |
processingContractMethodSend |
16791 ops/sec (±6.83% ) |
15153 ops/sec (±7.20% ) |
0.90 |
processingContractMethodCall |
27222 ops/sec (±7.95% ) |
27291 ops/sec (±6.06% ) |
1.00 |
abiEncode |
46089 ops/sec (±6.38% ) |
41796 ops/sec (±7.77% ) |
0.91 |
abiDecode |
30693 ops/sec (±7.35% ) |
28813 ops/sec (±7.30% ) |
0.94 |
sign |
1541 ops/sec (±1.02% ) |
1512 ops/sec (±0.76% ) |
0.98 |
verify |
366 ops/sec (±2.63% ) |
359 ops/sec (±0.56% ) |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
baseFeePerGas
at web3.eth.getFeeHistory
baseFeePerGas
at web3.eth.getFeeHistory
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7291 +/- ##
=======================================
Coverage 94.44% 94.44%
=======================================
Files 216 216
Lines 8463 8463
Branches 2339 2339
=======================================
Hits 7993 7993
Misses 470 470
Flags with carried forward coverage won't be shown. Click here to find out more. |
baseFeePerGas
at web3.eth.getFeeHistory
baseFeePerGas
at web3.eth.getFeeHistory
@@ -209,3 +209,7 @@ Documentation: | |||
- Add COMMITTED to BlockTags (#7124) | |||
|
|||
## [Unreleased] | |||
|
|||
### Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Fixed | |
### Changed |
so we bump major version as it will be breaking change for this fix, cc: @luu-alex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, requested a small change above
Description
Fixes #7135
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.