Refactor/aws integration #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manjish
requested review from
paudelgaurav,
dipeshdulal and
Denes-cilwal
and removed request for
paudelgaurav and
dipeshdulal
Denes-cilwal
requested changes
Apr 1, 2024
There was a problem hiding this comment.
@Manjish Let remove this cognito and upload file implementation. Adding up only and services is ok 🙏🏾
domain/user/module.go
Outdated
There was a problem hiding this comment.
@Manjish Let's remove this as auto migrate invocation and stick to writing migration for schema.
domain/user/repository.go
Outdated
Comment on lines
22
to
25
| // For AutoMigrating (used in fx.Invoke) | ||
| func Migrate(r Repository) error { | ||
| r.logger.Info("[Migrating...User]") | ||
| if err := r.DB.AutoMigrate(&models.User{}); err != nil { |
There was a problem hiding this comment.
Let revert these changes ! @Manjish
|
Please merge #114 before merging this PR |
…s-integration Refactor/enhancement in AWS integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Information
/api/upload-test/api/send-test-email