Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR-89 | Avatar Component #21

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

FR-89 | Avatar Component #21

wants to merge 7 commits into from

Conversation

itSubeDibesh
Copy link
Collaborator

@itSubeDibesh itSubeDibesh commented Apr 29, 2024

Overview πŸ“–

Explain the purpose of this PR and provide context for the changes.

πŸ”– Jira ticket: FR-89

Features πŸ› οΈ

List of features or changes included in this PR:

  • Implemented Avatar Component
  • Implemented Avatar storybook

Screenshots πŸ“Έ

Screenshot 2024-04-29 at 9 34 21β€―AM

Dependencies πŸ“¦

List any new dependencies required by this PR.

"@radix-ui/react-avatar": "^1.0.4",

Environment Changes πŸ”

No Environment change has been done ❌

Testing πŸ§ͺ

Instructions on how the reviewer can test the changes:

  • Run storybook using yarn storybook
  • Navigate avatar component and test it

Checklist βœ…

  • Implemented Avatar component and tested it using storybook

Copy link
Collaborator

@rodanr rodanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @itSubeDibesh , I just have few suggestions please work on it if you feel it make sense. Thank you.

src/components/atoms/Avatar/index.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@rodanr rodanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸš€

Copy link
Collaborator

@manojpudasaini manojpudasaini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ™‡

Copy link
Collaborator

@balraaz15 balraaz15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ™‡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants