-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ELY-2480] Add code coverage to the project #1941
base: 2.x
Are you sure you want to change the base?
Conversation
Hi @Dkafetzis , thanks a lot for the PR! |
Hello @Skyllarr, Yes i see now that some tests are not included in the coverage report. I'll look further into this, any suggestions on this are welcome. |
@Dkafetzis I tested this change using the latest 2.x code and I'm getting the following exception:
As a suggestion, we can use the latest version of OpenClover - 4.5.2 |
I updated it to the latest version. It works now on my machine, but feel free to try it out. Also try running it with |
@Skyllarr Can you also test this change? I'm still getting the below exception in my environment. Thanks! mvn clean install -Ptest-coverage org.openclover:clover-maven-plugin:aggregate org.openclover:clover-maven-plugin:clover
|
@ivassile This worked for me locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Dkafetzis! Have added a couple small comments.
@fjuma Can I also get a review on this one? |
@fjuma When you have a chance, can you review the requested changes? Thanks! |
@Dkafetzis Thanks very much for the updates, added a small comment but other than that, it looks good! Thanks very much! |
@fjuma Indentation fixed, thanks for the correction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Dkafetzis!
@Dkafetzis Can you please rebase? Thanks! |
@ivassile Done, sorry for the delay :) |
I was just trying to build with coverage before merging but unfortunately I get this error locally:
|
@Dkafetzis thank you for the work so far, FYI once we get this in it could be a good candidate to have a weekly GitHub action that generates this report so we can monitor (but that would be a follow up task, not part of this PR) |
https://issues.redhat.com/browse/ELY-2480
Added a new profile in maven to run test coverage for the elytron project. The profile name is "test-coverage"
Running the following will run the test coverage
mvn clean install -Ptest-coverage