-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ELY-2394] Add the ability to search for blog posts on the Elytron Blogs Page #2056
base: develop
Are you sure you want to change the base?
Conversation
7f6b53e
to
6f33c75
Compare
@gabrielpadilh4 Thank you very much for working on this! This is something that we've wanted to see added for quite a while! |
Hello @PrarthonaPaul can you please review ? |
1 similar comment
Hello @PrarthonaPaul can you please review ? |
Hello @gabrielpadilh4
Hello @gabrielpadilh4
Thanks! |
6f33c75
to
a4034c5
Compare
Hey @PrarthonaPaul @fjuma i have done the changes that you have asked. Can you please review it again ? Please let me know if you want to change something else :) |
Nice, thanks very much @gabrielpadilh4! One small comment, when searching multiple tags like "oidc bearer", we currently see separate results for each term. Is it possible to only display results that contain both terms or would that be difficult to do? |
Hi @fjuma i can try to do a cross check of the terms. Allow me sometime to try it out. |
Hey @fjuma @PrarthonaPaul the problem is that i'm searching in post title and post body, if the post has one of the terms in the title or in the body, it returns as a search result. I can change to only search in the post title, however, it will be limited. What do you think ? |
Hello @gabrielpadilh4
|
a4034c5
to
a6cf926
Compare
Hello @PrarthonaPaul @fjuma i have done the change, can you test it again ? |
a6cf926
to
461d2dd
Compare
Hello @gabrielpadilh4 |
461d2dd
to
699c875
Compare
ELY-2394 Add the ability to search for blog posts on the Elytron Blog…
699c875
to
a401a68
Compare
Thanks a lot for this @gabrielpadilh4! I've updated the version of lunr and made a minor change to how the terms are concatenated, so replaced by #2202 but you did all the work! |
Fixes: https://issues.redhat.com/browse/ELY-2394
Preview: https://gabrielpadilh4.github.io/wildfly-elytron/