Skip to content

Commit

Permalink
EJBCLIENT-500 Fix uses of deprecated elytron methods: AuthenticationC…
Browse files Browse the repository at this point in the history
…onfiguration.EMPTY, config.useMechanismProperties, setPasswordMap (#628)
  • Loading branch information
chengfang committed Jun 23, 2023
1 parent 5c426e8 commit 2a1cd64
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 20 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public AuthenticationContext getConfiguredAuthenticationContext() {
for (JBossEJBProperties.ConnectionConfiguration configuration : properties.getConnectionList()) {
// we don't actually care about the protocol for Elytron configuration
MatchRule rule = MatchRule.ALL.matchAbstractType("ejb", "jboss");
AuthenticationConfiguration config = AuthenticationConfiguration.EMPTY;
AuthenticationConfiguration config = AuthenticationConfiguration.empty();

final String host = configuration.getHost();
if (host == null) {
Expand All @@ -89,7 +89,7 @@ public AuthenticationContext getConfiguredAuthenticationContext() {
final JBossEJBProperties.ClusterConfiguration configuration = entry.getValue();

MatchRule defaultRule = MatchRule.ALL.matchAbstractType("ejb", "jboss");
AuthenticationConfiguration defaultConfig = AuthenticationConfiguration.EMPTY;
AuthenticationConfiguration defaultConfig = AuthenticationConfiguration.empty();

defaultRule = defaultRule.matchProtocol("cluster");
defaultRule = defaultRule.matchUrnName(clusterName);
Expand All @@ -105,7 +105,7 @@ public AuthenticationContext getConfiguredAuthenticationContext() {
if (nodeConfigurations != null) {
for (JBossEJBProperties.ClusterNodeConfiguration nodeConfiguration : nodeConfigurations) {
MatchRule rule = MatchRule.ALL.matchAbstractType("ejb", "jboss");
AuthenticationConfiguration config = AuthenticationConfiguration.EMPTY;
AuthenticationConfiguration config = AuthenticationConfiguration.empty();

rule = rule.matchProtocol("node");
rule = rule.matchUrnName(nodeConfiguration.getNodeName());
Expand Down Expand Up @@ -147,7 +147,7 @@ private static AuthenticationConfiguration configureCommon(final JBossEJBPropert
@SuppressWarnings({"unchecked", "rawtypes"})
final Map<String, String> props = (Map) SaslUtils.createPropertyMap(options, false);
if (! props.isEmpty()) {
config = config.useMechanismProperties(props);
config = config.useSaslMechanismProperties(props);
}
if (options.contains(Options.SASL_DISALLOWED_MECHANISMS)) {
config = config.setSaslMechanismSelector(SaslMechanismSelector.DEFAULT.forbidMechanisms(options.get(Options.SASL_DISALLOWED_MECHANISMS).toArray(NO_STRINGS)));
Expand Down
39 changes: 23 additions & 16 deletions src/test/java/org/jboss/ejb/client/test/common/DummyServer.java
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,20 @@
*/
package org.jboss.ejb.client.test.common;

import java.io.IOException;
import java.net.InetAddress;
import java.net.InetSocketAddress;
import java.net.SocketAddress;
import java.net.UnknownHostException;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.concurrent.ConcurrentHashMap;
import java.util.function.Function;

import org.jboss.ejb.client.EJBModuleIdentifier;
import org.jboss.ejb.protocol.remote.RemoteEJBService;
import org.jboss.ejb.server.Association;
Expand All @@ -33,9 +47,13 @@
import org.jboss.remoting3.ServiceRegistrationException;
import org.jboss.remoting3.spi.NetworkServerProvider;
import org.wildfly.security.auth.realm.SimpleMapBackedSecurityRealm;
import org.wildfly.security.auth.realm.SimpleRealmEntry;
import org.wildfly.security.auth.server.MechanismConfiguration;
import org.wildfly.security.auth.server.SaslAuthenticationFactory;
import org.wildfly.security.auth.server.SecurityDomain;
import org.wildfly.security.auth.server.SaslAuthenticationFactory;
import org.wildfly.security.authz.Attributes;
import org.wildfly.security.credential.Credential;
import org.wildfly.security.credential.PasswordCredential;
import org.wildfly.security.password.interfaces.ClearPassword;
import org.wildfly.security.permission.PermissionVerifier;
import org.wildfly.security.sasl.util.SaslFactories;
Expand All @@ -48,20 +66,6 @@
import org.xnio.Xnio;
import org.xnio.channels.AcceptingChannel;

import java.io.IOException;
import java.net.InetAddress;
import java.net.InetSocketAddress;
import java.net.SocketAddress;
import java.net.UnknownHostException;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.concurrent.ConcurrentHashMap;
import java.util.function.Function;

/**
* @author <a href="mailto:[email protected]">Carlo de Wolf</a>
* @author <a href="mailto:[email protected]">Richard Achmatowicz</a>
Expand Down Expand Up @@ -143,7 +147,10 @@ public void start() throws Exception {

// set up a security realm called default with a user called test
final SimpleMapBackedSecurityRealm realm = new SimpleMapBackedSecurityRealm();
realm.setPasswordMap("test", ClearPassword.createRaw(ClearPassword.ALGORITHM_CLEAR, "test".toCharArray()));
final ClearPassword password = ClearPassword.createRaw(ClearPassword.ALGORITHM_CLEAR, "test".toCharArray());
final List<Credential> credentials = Collections.singletonList(new PasswordCredential(password));
final SimpleRealmEntry realmEntry = new SimpleRealmEntry(credentials, Attributes.EMPTY);
realm.setIdentityMap(Collections.singletonMap("test", realmEntry));

// set up a security domain which has realm "default"
final SecurityDomain.Builder domainBuilder = SecurityDomain.builder();
Expand Down

0 comments on commit 2a1cd64

Please sign in to comment.