Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better TRACE-level debugging for EJBClientInvocationContext state machine #660

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rachmatowicz
Copy link
Contributor

This is a draft pull request to add better trace level logging to EJBCientInvocationContext state machine.

@rachmatowicz
Copy link
Contributor Author

rachmatowicz commented Sep 21, 2023

The idea was to do two things:

  • add in DEBUG level lohgging on more of the methods which were not getting visiility, like cancellation, discarding, failing, result ready,...
  • for all state machine methods, add TRACE level debugging on most of the state transactions and conditions

This may require a bit of tweaking to get the balance right. We should probably also use the Logs.INVOCATION logger for the trace level messages as well (i.e. not log.tracef() but Logs.INVOCATION.tracef())

Copy link
Contributor

@tadamski tadamski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rachmatowicz I would go on and merge this branch and we can fine-tune later if necessary wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants