-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdk/tests: check all packages are up to date #97
Conversation
Signed-off-by: Dimitri John Ledkov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this test ever fail? The only way I see for it to fail is if bash isn't present in the image.
Its not clear to me what this will accomplish. Can you give an example of a failure that it would catch?
At first I am adding it as If it passes without printing errors on a few runs, will submit a pr to drop the The point is to catch package reorgs, which end up resolving and building images with out of date packages, like we had with libxcrypt transition. |
@smoser ideally i want this check to be merged, before doing part ii merge of wolfi-dev/os#15069 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good for now. we just have to remember to drop it.
Check that everything is up to date
Freshly minted image, should be fully up to date, this however will catch any package renames/provides that apko resolved using out of date packages, due to packaging mistakes or ongoing transitions
Non-fatal for now
Related: wolfi-dev/os#14692
CC @smoser