Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes- State dropdown not showing exact match #20

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

nishitlangaliya
Copy link

Fixes: State dropdown not showing exact match ref # woocommerce/woocommerce#20605

As per suggestion PR done

This pull request includes a

  • Bug fix
  • New feature
  • Translation

The following changes were made

If this is related to an existing ticket, include a link to it as well.

@claudiulodro
Copy link

Hi. Thanks for the effort.

This feature is not going to be so straightforward.

This change does show Washington as the first result when typing "wa" into the checkout, but it will not show any states that don't start with "wa" (e.g. Delaware, Iowa):

screen shot 2018-07-05 at 12 23 39 pm

Also, this means that you cannot now find Washington with the search "ton", "ashington", etc.

What it needs is to show Washington as the first result when searching for "wa" and all of the other results need to be present in the same order they were before:

screen shot 2018-07-05 at 12 35 18 pm

It's a much trickier issue, and I don't think we can solve it until we define what the correct algorithm should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants