Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue in signing into another WP.com account #23654

Open
wants to merge 4 commits into
base: bugfix/find-correct-account-for-jetpack-sites
Choose a base branch
from

Conversation

crazytonyli
Copy link
Contributor

This PR is built on top of #23644.

This PR fixes an issue with having multiple WP.com accounts in the app. Here are steps to reproduce the issue.

  1. Create a self-hosted site and connect it to WP.com account A.
  2. Open Jetpack app and sign in using WP.com account B.
  3. Add the self-hosted site in step 1.
  4. Tap "Stats" of the self-hosted site. You'll see a "Log in" button here.
  5. Tap the Log in button to sign in with WP.com account A.

Expected behaviour: the app displays Stats content after successful login.

Actual behaviour: the app is kind of messed up, because it incorrectly saves the second WP.com account as the default account.

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23654-c3e32dd
Version25.4
Bundle IDcom.jetpack.alpha
Commitc3e32dd
App Center Buildjetpack-installable-builds #9824
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23654-c3e32dd
Version25.4
Bundle IDorg.wordpress.alpha
Commitc3e32dd
App Center BuildWPiOS - One-Offs #10782
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants