fix tests by supporting only src attribute if it's found

wp-media · Jun 6, 2024 · fbc765e · fbc765e
1 parent c46e6ca
commit fbc765e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/inc/Engine/Media/AboveTheFold/AJAX/Controller.php b/inc/Engine/Media/AboveTheFold/AJAX/Controller.php
@@ -261,7 +261,7 @@ public function check_lcp_data() {
 	 * @return bool
 	 */
 	private function validate_image( $image_object ) {
-		$valid_image = $this->validate_image_src( $image_object->src ?? '' );
+		$valid_image = ! empty( $image_object->src ) ? $this->validate_image_src( $image_object->src ?? '' ) : true;
 
 		/**
 		 * Filters If the image src is a valid image or not.

diff --git a/tests/Fixtures/inc/Engine/Media/AboveTheFold/AJAX/Controller/addLcpData.php b/tests/Fixtures/inc/Engine/Media/AboveTheFold/AJAX/Controller/addLcpData.php
@@ -312,7 +312,7 @@
 					(object) [
 						'label' => 'lcp',
 						'type'  => 'bg-img',
-						'src'   => 'http://example.org/lcp.jpg',
+						'src'   => '',
 						'bg_set' => [
 							[
 								'src' => 'http://example.org/anotherlcp.jpg'
@@ -428,6 +428,10 @@
 					],
 				]
 			),
+			'filetype' => [
+				'ext' => 'jpg',
+				'type' => 'image/jpeg',
+			],
 		],
 		'expected' => [
 			'images_valid_sources' => [],