Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub action error while saving DelayJS lists because json file is too large #6055

Closed
4 tasks
engahmeds3ed opened this issue Jul 19, 2023 · 1 comment · Fixed by #6088
Closed
4 tasks

GitHub action error while saving DelayJS lists because json file is too large #6055

engahmeds3ed opened this issue Jul 19, 2023 · 1 comment · Fixed by #6088
Labels
dev initiative needs: r&d Needs research and development (R&D) before a solution can be proposed and scoped. priority: medium Issues which are important, but no one will go out of business. severity: moderate Feature isn't working as expected but has work around to get same value type: bug Indicates an unexpected problem or unintended behavior

Comments

@engahmeds3ed
Copy link
Contributor

Before submitting an issue please check that you’ve completed the following steps:

  • Made sure you’re on the latest version Yes, it's not a plugin related issue, it's devops.
  • Used the search feature to ensure that the bug hasn’t been reported before Yes

Describe the bug
When releasing, we have github action to get latest json file from our backend and save commit it to develop branch before releasing as a fallback data provider.
The json file started to be bigger and we face exactly this issue:
jsdaniell/create-json#5

So we need to find a better way to save this json file

To Reproduce
Steps to reproduce the behavior:

  1. Create a pull request from develop to trunk
  2. Check the actions
  3. You will find a failure as in here: https://github.com/wp-media/wp-rocket/actions/runs/5587635026/jobs/10213256511

Expected behavior
Json file should be created and committed without any problem.

Backlog Grooming (for WP Media dev team use only)

  • Reproduce the problem
  • Identify the root cause
  • Scope a solution
  • Estimate the effort
@piotrbak piotrbak added type: bug Indicates an unexpected problem or unintended behavior priority: medium Issues which are important, but no one will go out of business. dev initiative needs: r&d Needs research and development (R&D) before a solution can be proposed and scoped. severity: moderate Feature isn't working as expected but has work around to get same value labels Jul 19, 2023
@engahmeds3ed
Copy link
Contributor Author

I started exploring how to create a new action for us based on the current action and did a small thing here:
https://github.com/engahmeds3ed/create-json-url

I did some tests in this PR:
#6088

and still on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev initiative needs: r&d Needs research and development (R&D) before a solution can be proposed and scoped. priority: medium Issues which are important, but no one will go out of business. severity: moderate Feature isn't working as expected but has work around to get same value type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants