Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype: Test a new GitHub action for json #6088

Merged
merged 26 commits into from
Aug 9, 2023

Conversation

engahmeds3ed
Copy link
Contributor

@engahmeds3ed engahmeds3ed commented Aug 3, 2023

Fixes #6055

For testing/QA you need to Change the lists from backend and push a dummy commit to this branch to trigger getting those changes.

After finishing this PR and before merging we need to change those lines:

push:
branches: [ "trunk", "prototype/github-action-for-json" ]
pull_request:
branches: [ "trunk", "prototype/github-action-for-json" ]

to remove the current branch name that was added for testing.

@engahmeds3ed engahmeds3ed self-assigned this Aug 3, 2023
@engahmeds3ed engahmeds3ed marked this pull request as ready for review August 8, 2023 11:08
@engahmeds3ed engahmeds3ed requested a review from a team August 8, 2023 11:08
@vmanthos vmanthos self-requested a review August 9, 2023 11:46
Copy link
Contributor

@vmanthos vmanthos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected! 👍

@engahmeds3ed
Copy link
Contributor Author

@vmanthos that's ready to be merged

@vmanthos vmanthos added this pull request to the merge queue Aug 9, 2023
Merged via the queue into develop with commit b73125b Aug 9, 2023
7 checks passed
@vmanthos vmanthos deleted the prototype/github-action-for-json branch August 9, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub action error while saving DelayJS lists because json file is too large
3 participants