Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.17 - Refactor Cron #6781

Closed
jeawhanlee opened this issue Jul 12, 2024 · 0 comments · Fixed by #6797 or #6831
Closed

3.17 - Refactor Cron #6781

jeawhanlee opened this issue Jul 12, 2024 · 0 comments · Fixed by #6797 or #6831
Assignees
Labels
effort: [S] 1-2 days of estimated development time
Milestone

Comments

@jeawhanlee
Copy link
Contributor

Description:

This issue focuses on the proposed refactor of the Admin process within the AboveTheFold feature. The goal is to make the Cron process more generic and reusable for other features. This involves moving the Cron process from the AboveTheFold namespace to the PerformanceHints namespace within Common. The Common namespace will serve as a central location for processes that are generic and shared across features.

Scope a solution:

  • Move the Cron folder from AboveTheFold to PerformanceHints within Common.
  • Remove all references to the Cron module in AboveTheFold\ServiceProvider
  • Update the Common\PerformanceHints\ServiceProvider if created and if not create it and reflect the new location of the Cron module.
  • Thoroughly test the Cron process in its new location to ensure it works as expected and maintains its functionality.
  • Update any documentation or comments in the codebase to reflect the change in location of the Cron process.

Acceptance Criteria

  • There should be no regression for this module
  • All tests should be green and passing.
@jeawhanlee jeawhanlee added the effort: [S] 1-2 days of estimated development time label Jul 12, 2024
@piotrbak piotrbak added this to the 3.17 milestone Jul 17, 2024
@Khadreal Khadreal self-assigned this Jul 18, 2024
@Khadreal Khadreal linked a pull request Jul 18, 2024 that will close this issue
18 tasks
Khadreal added a commit that referenced this issue Jul 23, 2024
Khadreal added a commit that referenced this issue Jul 23, 2024
jeawhanlee added a commit that referenced this issue Jul 26, 2024
@jeawhanlee jeawhanlee linked a pull request Jul 30, 2024 that will close this issue
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: [S] 1-2 days of estimated development time
Projects
None yet
3 participants