Closes #6781: 3.17 - Refactor Cron

[Khadreal]

Description

Fixes #6781

Documentation

User documentation

Nothing changed on user side.

Explain how this code impacts users.

Technical documentation

Move cron controller and subscriber from ATF to PerformanceHints.

Type of change

• Enhancement (non-breaking change which improves an existing functionality).

New dependencies

List any new dependencies that are required for this change.

Risks

List possible performance & security issues or risks, and explain how they have been mitigated.

Checklists

Feature validation

• I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
• I triggered all changed lines of code at least once without new errors/warnings/notices.

Documentation

• I prepared the user documentation for the feature/enhancement and shared it in the PR or the GitHub issue.
• The user documentation covers new/changed entry points (endpoints, WP hooks, configuration files, ...).
• I prepared the technical documentation if needed, and shared it in the PR or the GitHub issue.

Code style

• I wrote self-explanatory code about what it does.
• I wrote comments to explain why it does it.
• I named variables and functions explicitely.
• I protected entry points against unexpected inputs.
• I did not introduce unecessary complexity.
• I listed the introduced external dependencies explicitely on the PR.
• I validated the repo-specific guidelines from CONTRIBUTING.md.

Observability

• I handled errors when needed.
•  I wrote user-facing messages that are understandable and provide actionable feedbacks.
• I prepared ways to observe the implemented system (logs, data, etc.).

Risks

•  I explicitely mentioned performance risks in the PR.
• I explicitely mentioned security risks in the PR.

[jeawhanlee]

Moving this back to in progress.
Cron tests were not refactored..

[Khadreal]

Moving this back to in progress. Cron tests were not refactored..

Will add test for it, don't think we have one before now

[jeawhanlee]

Moving this back to in progress. Cron tests were not refactored..

Will add test for it, don't think we have one before now

I can see one here: https://github.com/wp-media/wp-rocket/tree/subtask/6781-3.17-refactor-cron/tests/Integration/inc/Engine/Media/AboveTheFold/Cron/Subscriber

[jeawhanlee]

I have temporarily changed the base branch to develop so git actions and automated tests can be triggered when you push.

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
✅ -0.01% (target: -0.10%)	❌ 23.08% (target: 50.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (b87f0fb)	37492	14610	38.97%
Head commit (3d2ff0c)	37500 (+8)	14610 (+0)	38.96% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#6797)	26	6	23.08%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

---

_{🚀 Don’t miss a bit, follow what’s new on Codacy.}

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

[jeawhanlee]

Merge 3.17-atf-refactor branch and fix the conflicts