-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix WPML clearing all languages cache #6263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The doc to fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check if there was other instances of callbacks on after_rocket_clean_domain
that could be replaced to optimize this?
That's a good point, I saw some cases but I wasn't sure if we need to do this here and overload this PR or not, but I believe u r correct, let me check them and see. |
… making sure that this will work
@wordpressfan Thanks for the PR. A request is done once now when changing settings, full cache clear from admin, clearing used CSS, changing permalinks (assuming that all will trigger this function wp-rocket/inc/Engine/Preload/Subscriber.php Line 285 in b67069f
|
When we switch theme we are hooking First location: wp-rocket/inc/common/purge.php Line 16 in afef3b6
Second location: wp-rocket/inc/common/purge.php Line 8 in afef3b6
Third and main location: wp-rocket/inc/common/purge.php Line 6 in afef3b6
I believe this is another issue. cc @piotrbak |
@Mai-Saad @wordpressfan Yes, this is different issue. Let's go with separate issue for this one |
Working as expected then. (Note, the behavior when switch theme is the same even without WPML) |
The other issue is created here: #6276 |
Description
Here we introduced a new filter that runs after clearing cache and used in preload as in the issue's grooming.
Fixes #6214
Type of change
Please delete options that are not relevant.
Is the solution different from the one proposed during the grooming?
Exactly as it's groomed.
Checklists
Generic development checklist
Test summary
If not, detail what you could not test.
Please describe any additional tests you performed.