-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #6273 Exclude JS module type from minification #6277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code seems valid. However @piotrbak already created a PR to create a exclusion list maintained by the backend for that issue : https://github.com/wp-media/rucss-backend/issues/83
@CrochetFeve0251 @Tabrisrp Apologies, thought that the grooming will happen. I added this issue to the backen repository, so we could move this part there: wp-rocket/inc/Engine/Optimization/Minify/JS/AbstractJSOptimization.php Lines 100 to 104 in 3abb772
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences🚀 Don’t miss a bit, follow what’s new on Codacy. Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
Description
Exclude
type="module"
scripts from JS mifinicationFixes #6273
Type of change
Is the solution different from the one proposed during the grooming?
XS issue, no grooming
Checklists
Generic development checklist
Test summary