-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preload adaptative batch #6427
Merged
Merged
Preload adaptative batch #6427
Changes from 44 commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
f5f5e03
Rework Preload process_pending_jobs to adapt batch size based on prev…
MathieuLamiot fbdeb7e
Rework the batch size to depend on a request duration measurement
MathieuLamiot 375d2ec
Set transient expiration
MathieuLamiot a0af9fc
Move code around to limit changes
MathieuLamiot c5763cf
Compute all request duration, used to determine the next batch size
Khadreal 42f85be
Modified computation as suggested by @mathieu
Khadreal 52eab5f
Clean float to int conversion
MathieuLamiot 38fe3e4
Prevent the check_duration to happen for every AS task
MathieuLamiot 73c7dbc
Bring back behaviors like delay_between and limit on number of pendin…
MathieuLamiot 979e196
Fix blocking headers that was not applied
MathieuLamiot 640b383
Adjust batch size formula based on local and gamma experiments
MathieuLamiot 4716dc6
Merge commit '163edfebd3cfa77be5ae824858755af9034a9915' into prototyp…
MathieuLamiot 7eb83c9
fix linter
MathieuLamiot 320bc7e
Fix typo while fixing linter... duh
MathieuLamiot 2986803
Improve testing
Khadreal 93c3e48
Add get-transient method to test method
Khadreal 0cfb05e
Fixed undefined test error
Khadreal 159840d
Modified test method :phew:
Khadreal ab3c7bf
Modified testing
Khadreal 0865788
Fixed test error :feat:
Khadreal 4b9f966
fixed integration test
Khadreal 3761107
Add transients
Khadreal 25a43d0
fixed lint error
Khadreal 3c70603
Review modifications, add comment to filter
Khadreal 18f4178
code modification :sparkles:
Khadreal c4cca9c
Change package version and modify preload url loop
Khadreal a1662ff
Make the max size of the preload batch the top priority constraint to…
MathieuLamiot 8951cc3
Fix tests
MathieuLamiot 3a9a2ad
InProgressShouldNotExceedMaxQueue data set needs update
MathieuLamiot 959f8f8
Merge branch 'develop' into prototype/preload-adaptative-batch
Tabrisrp cd57efa
update test config
Tabrisrp ba634ac
fix function name
Tabrisrp 8e8e205
update count expectation
Tabrisrp d6beb2f
force int type
Tabrisrp daba361
cleanup
Tabrisrp 16f4dbb
update expectations
Tabrisrp 1c7b9c2
update test config
Tabrisrp 70f0f71
update condition
Tabrisrp 1b99daa
add test for check duration
Tabrisrp 2483a46
update transient name and code
Tabrisrp 9d68828
update transient name
Tabrisrp f806482
improve expectations for transients
Tabrisrp b1ab24b
rename variable
Tabrisrp d00b8ee
code cleanup
Tabrisrp b3a1d27
Merge commit '5b286ce8c571285bd0924f8f223440e7f9f4c0b4' into prototyp…
MathieuLamiot 2f34f9d
add logs
MathieuLamiot f016139
Fix log typo
MathieuLamiot 48f03ee
Revert "Fix log typo"
MathieuLamiot eeb8c34
Revert "add logs"
MathieuLamiot 43fbc5d
revert logs as we have the transients already
MathieuLamiot 495d749
Revert "revert logs as we have the transients already"
MathieuLamiot f4c9af6
cast next_batch_size to int
MathieuLamiot cab5b28
fix linter
MathieuLamiot 57eb141
Merge branch 'refs/heads/develop' into prototype/preload-adaptative-b…
wordpressfan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's not been added by this PR, but shouldn't we add a safeguard here ?