Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6590 Add LCP/ATF warmup for mobile version #6600

Merged
merged 212 commits into from
May 2, 2024

Conversation

Tabrisrp
Copy link
Contributor

@Tabrisrp Tabrisrp commented Apr 26, 2024

Description

Add LCP/ATF warmup for mobile version if the mobile options are enabled.

Fixes #6590

Documentation

Technical documentation

Added an additional request and process using a mobile user agent. Updated the methods to use a $device parameter, with default value desktop.

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.

Tabrisrp and others added 30 commits October 16, 2023 07:49
Co-authored-by: Rémy Perona <[email protected]>
Co-authored-by: Rémy Perona <[email protected]>
@Tabrisrp Tabrisrp changed the base branch from develop to feature/lcp-above-the-fold-optimization April 26, 2024 19:34
@Tabrisrp Tabrisrp self-assigned this Apr 26, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -0.10%) 55.56% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (764aaf2) 36991 14178 38.33%
Head commit (1650c95) 36998 (+7) 14182 (+4) 38.33% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6600) 9 5 55.56%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Copy link

codacy-production bot commented Apr 26, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -0.10%) 55.56% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (985a76b) 37115 14321 38.59%
Head commit (9f01ffd) 37122 (+7) 14325 (+4) 38.59% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6600) 9 5 55.56%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Base automatically changed from feature/lcp-above-the-fold-optimization to branch-3.16 April 29, 2024 19:42
@Tabrisrp Tabrisrp changed the base branch from branch-3.16 to develop April 29, 2024 19:49
@Tabrisrp Tabrisrp added this to the 3.16 milestone Apr 29, 2024
@Tabrisrp Tabrisrp requested a review from a team May 1, 2024 20:18
@Tabrisrp Tabrisrp added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement lcp labels May 1, 2024
@Tabrisrp Tabrisrp marked this pull request as ready for review May 1, 2024 20:19
Copy link

@hanna-meda hanna-meda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tabrisrp Tabrisrp added this pull request to the merge queue May 2, 2024
Merged via the queue into develop with commit 74186d3 May 2, 2024
13 of 14 checks passed
@Tabrisrp Tabrisrp deleted the fix/6590-warmup-mobile branch May 2, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warmup needs to generate desktop and mobile data
7 participants