Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6613 Improve LCP warmup process #6615

Merged
merged 8 commits into from
May 7, 2024
Merged

Fixes #6613 Improve LCP warmup process #6615

merged 8 commits into from
May 7, 2024

Conversation

Tabrisrp
Copy link
Contributor

@Tabrisrp Tabrisrp commented May 3, 2024

Description

Update the LCP warmup process by:

  • Doing only a request on the mobile homepage
  • Reducing the delay between each URL sent to the SaaS
  • Making the requests non-blocking

Fixes #6613

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.

@Tabrisrp Tabrisrp added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement lcp labels May 3, 2024
@Tabrisrp Tabrisrp added this to the 3.16 milestone May 3, 2024
@Tabrisrp Tabrisrp self-assigned this May 3, 2024
Copy link

codacy-production bot commented May 3, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.07% (target: -0.10%) 36.36% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (74186d3) 37122 14325 38.59%
Head commit (118c59e) 37189 (+67) 14377 (+52) 38.66% (+0.07%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6615) 22 8 36.36%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@Tabrisrp Tabrisrp marked this pull request as ready for review May 3, 2024 20:38
@Tabrisrp Tabrisrp requested a review from a team May 3, 2024 20:38
@Tabrisrp Tabrisrp requested a review from wordpressfan May 6, 2024 14:35
@jeawhanlee
Copy link
Contributor

@Tabrisrp @wordpressfan This is totally out of scope for this PR but I figured since we already touched here, we might as well just do it. For easier debugging, can we add the url to the response log here:


Perhaps something like this: https://example.org/lcp-page - Add to queue response body

@Tabrisrp Tabrisrp added this pull request to the merge queue May 7, 2024
Merged via the queue into develop with commit 1728543 May 7, 2024
11 of 14 checks passed
@Tabrisrp Tabrisrp deleted the fix/6613-warmup branch May 7, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements to homepage fetching process
4 participants