Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6541 Add PHPStan CI & level 0 errors #6617

Merged
merged 12 commits into from
May 8, 2024

Conversation

Tabrisrp
Copy link
Contributor

@Tabrisrp Tabrisrp commented May 6, 2024

Description

  • Adds PHPStan to our CI
  • Fixes level 0 errors reported by PHPStan

Fixes #6541

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Checklists

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I did not introduce unecessary complexity.

Observability

  • I handled errors when needed.

Copy link

codacy-production bot commented May 6, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -0.10%) 30.00% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (cccbadf) 37177 14376 38.67%
Head commit (1da63ca) 37192 (+15) 14377 (+1) 38.66% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6617) 10 3 30.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@Tabrisrp Tabrisrp self-assigned this May 7, 2024
@Tabrisrp Tabrisrp requested a review from a team May 7, 2024 18:26
@Tabrisrp Tabrisrp marked this pull request as ready for review May 7, 2024 18:28
@Tabrisrp Tabrisrp added this pull request to the merge queue May 8, 2024
Merged via the queue into develop with commit 2b088a3 May 8, 2024
13 of 15 checks passed
@Tabrisrp Tabrisrp deleted the enhancement/6541-phpstan branch May 8, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporate PHPStan for Static Analysis
2 participants