Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests cleanup #6622

Merged
merged 9 commits into from
May 9, 2024
Merged

Unit tests cleanup #6622

merged 9 commits into from
May 9, 2024

Conversation

Tabrisrp
Copy link
Contributor

@Tabrisrp Tabrisrp commented May 8, 2024

Description

Cleanup the unit tests suite:

  • Add missing fixtures file
  • Remove no longer used/empty tests files
  • Fix deprecation warning

Sub-task of #6607

Type of change

  • Bug fix (non-breaking change which fixes an issue).

@Tabrisrp Tabrisrp self-assigned this May 8, 2024
@Tabrisrp Tabrisrp marked this pull request as ready for review May 8, 2024 15:04
@Tabrisrp Tabrisrp requested a review from a team May 8, 2024 15:04
Copy link

codacy-production bot commented May 8, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 2b088a31 (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2b088a3) Report Missing Report Missing Report Missing
Head commit (2d8f18a) 37183 14396 38.72%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6622) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@jeawhanlee
Copy link
Contributor

jeawhanlee commented May 9, 2024

Does this fix cover PHP 8.1, 8.2 & 8.3 as there's still deprecated warning for it:
WP latest with PHP 8.3 on ubuntu-latest.

@Tabrisrp
Copy link
Contributor Author

Tabrisrp commented May 9, 2024

Good catch, I didn't check those ones. I removed the invalid annotations.

For the warnings created by str_replace(), I'll open an issue on the library to fix this upstream

@Tabrisrp Tabrisrp added this pull request to the merge queue May 9, 2024
Merged via the queue into develop with commit 770c397 May 9, 2024
14 checks passed
@Tabrisrp Tabrisrp deleted the fix/unit-tests-cleanup branch May 9, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants