Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #6668 Display Clear critical images on local environment #6671

Merged
merged 1 commit into from
May 31, 2024

Conversation

Tabrisrp
Copy link
Contributor

@Tabrisrp Tabrisrp commented May 27, 2024

Description

Display the clear critical images button on local environment (when RUCSS is disabled).

Fixes #6668

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.
  • I implemented built-in tests to cover the new/changed code.

Code style

  • I wrote self-explanatory code about what it does.
  • I wrote comments to explain why it does it.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.

@Tabrisrp Tabrisrp self-assigned this May 27, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 0a34f3e1 66.67% (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0a34f3e) Report Missing Report Missing Report Missing
Head commit (2fc81c8) 37188 14390 38.70%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6671) 6 4 66.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@Tabrisrp Tabrisrp marked this pull request as ready for review May 27, 2024 23:10
@jeawhanlee jeawhanlee self-requested a review May 31, 2024 08:41
@jeawhanlee
Copy link
Contributor

jeawhanlee commented May 31, 2024

Clear Critical images is now displayed on local env.
Screenshot 2024-05-31 at 14 00 30

Screenshot 2024-05-31 at 14 01 44

Screenshot 2024-05-31 at 14 12 50

@jeawhanlee jeawhanlee added this pull request to the merge queue May 31, 2024
Merged via the queue into develop with commit 219639e May 31, 2024
14 checks passed
@jeawhanlee jeawhanlee deleted the enhancement/6668-clear-critical-images branch May 31, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Clear Critical Images button on local environment
3 participants