Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6679 Correctly reference sourcemap filename in LCP script #6681

Merged
merged 6 commits into from
Jun 3, 2024

Conversation

Tabrisrp
Copy link
Contributor

Description

Update the gulp build task to rename before creating the sourcemap, so that the sourcemap filename is correct in both the minified file, and in the assets folder

Fixes #6679

Type of change

  • Bug fix (non-breaking change which fixes an issue).

Checklists

Feature validation

  • I validated all the Acceptance Criteria. If possible, provide sreenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

  • I wrote self-explanatory code about what it does.
  • I named variables and functions explicitely.
  • I protected entry points against unexpected inputs.
  • I did not introduce unecessary complexity.
  • I validated the repo-specific guidelines from CONTRIBUTING.md.

@Tabrisrp Tabrisrp added the type: bug Indicates an unexpected problem or unintended behavior label May 30, 2024
@Tabrisrp Tabrisrp requested a review from a team May 30, 2024 14:44
@Tabrisrp Tabrisrp self-assigned this May 30, 2024
Copy link

codacy-production bot commented May 30, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 350b61e1 (target: 50.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (350b61e) Report Missing Report Missing Report Missing
Head commit (7a5b859) 37230 14396 38.67%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#6681) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

# Conflicts:
#	assets/js/lcp-beacon.js.min.map
#	assets/js/lcp-beacon.min.js
Copy link
Contributor

@wordpressfan wordpressfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

I only fixed merge conflicts because this was conflicting with this PR: #6677

@Miraeld
Copy link
Contributor

Miraeld commented Jun 2, 2024

Works great !

@Tabrisrp Tabrisrp added this pull request to the merge queue Jun 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jun 3, 2024
@Tabrisrp Tabrisrp added this pull request to the merge queue Jun 3, 2024
Merged via the queue into develop with commit 4f65077 Jun 3, 2024
14 checks passed
@Tabrisrp Tabrisrp deleted the fix/6679-sourcemap branch June 3, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create lcp-beacon.js.map file to prevent 404 errors
3 participants