-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #6679 Correctly reference sourcemap filename in LCP script #6681
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more Footnotes
|
# Conflicts: # assets/js/lcp-beacon.js.min.map # assets/js/lcp-beacon.min.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!
I only fixed merge conflicts because this was conflicting with this PR: #6677
Works great ! |
Description
Update the gulp build task to rename before creating the sourcemap, so that the sourcemap filename is correct in both the minified file, and in the assets folder
Fixes #6679
Type of change
Checklists
Feature validation
Code style